Fix get_jobs method in Comparison Monitor #444
Conversation
VMRuiz
force-pushed
the
feature/fix-get_jobs
branch
from
aacecaf to
f12a87c
Compare
|
Force pushed branch again to remove incorrectly staged files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 79.37% 79.39% +0.01%
==========================================
Files 76 76
Lines 3234 3237 +3
Branches 537 537
==========================================
+ Hits 2567 2570 +3
Misses 595 595
Partials 72 72 ☔ View full report in Codecov by Sentry. |
| start=start, | ||
| state=states, | ||
| count=number_of_jobs, | ||
| count=count, | ||
| filters=dict(has_tag=tags) if tags else None, |
There was a problem hiding this comment.
issue (non-blocking): This was already like this, so we might need to update it in another PR, but filters=dict(has_tag=tags) if tags else None doesn't do anything, at least in the version of scrapinghub I'm using (2.4.0). has_tag=tags as a parameter by itself, without the filters wrap, does filter the jobs, though I'm not sure if that's backward compatible.
There was a problem hiding this comment.
Is there any other issues about this?
There was a problem hiding this comment.
Is there any other issues about this?
There was a problem hiding this comment.
No that I know of, no! And that issue is not related to these changes. We should be good to merge 👍
Fixes #442